lint: Improve t-060 #768
Merged
lint: Improve t-060 #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned, add several missing book names and/or standard abbreviations. I updated the test to test everything; otherwise, if things need to be added/changed, as now, the test wouldn't confirm it was done correctly.
Thanks for the quick fix on the comma issue; maybe one of these days I'll convince my brain to learn how to speak xpath.
Also, as a note, "Revelations" is incorrect—the book name is not and never has been plural. With Psalms, the book name is Psalms, but when referring to an individual psalm, it's referred to in the singular, i.e. Psalm 20, not Psalms 20. If we run into those, IMO they should be (editorially) corrected; they were wrong then, they're wrong today. I'm speaking in terms of the same kind of situation as t-060. They should still be corrected if we run across them in prose (… the twelfth chapter of Revelations was always…), but I don't think that could be a rule, just up to the individual producer/editor.