Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nudge the placeholder ribbon left 2px, past the border #442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

colagrosso
Copy link
Collaborator

To my eye, the ribbon should fold against the outside edge of the border.

Before:
Screenshot_2024-12-16_00-16-20

After:
Screenshot_2024-12-16_00-20-05

(The "In Use" ribbon on artwork looks right because it's placed on a higher element, before the border is applied.)

@acabal
Copy link
Member

acabal commented Dec 16, 2024

Good catch. But let's tweak the CSS a little - we want the .ribbon to be reusable and the exception case is the placeholder, which has a thicker border. So we should only adjust the position for placeholders, not every single ribbon. (For example, in case in the future we want to add a ribbon to a regular ebook?)

@acabal acabal force-pushed the master branch 7 times, most recently from 0ebbab9 to 97021ce Compare December 17, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants