Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add segment ids/sequence masking #827

Merged
merged 14 commits into from
Dec 3, 2024
Merged

Add segment ids/sequence masking #827

merged 14 commits into from
Dec 3, 2024

Conversation

dlwh
Copy link
Member

@dlwh dlwh commented Dec 2, 2024

Should have done this a long time ago, but it didn't seem that important.

Turns out it's a small but non-zero win:

image

Copy link
Contributor

@blahBlahhhJ blahBlahhhJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlwh dlwh merged commit 578fb5b into main Dec 3, 2024
8 checks passed
@dlwh dlwh deleted the segment_ids branch December 3, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants