aggressive handling of special characters in naming #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace all the things in ItemBracketHandler. Actually, the preferred solution would be to just properly handle these cases. Will fix issues with, for example, Tinkers-Defense Queen's Gold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all the things in ItemBracketHandler.
Actually, the preferred solution would be to just properly handle these cases.
Will fix issues with, for example, Tinkers-Defense Queen's Gold
I found this patch when I was reviewing old code in my forks. See if it's useful for you or not. If I remember correctly, there were issues with some items that use special characters in their name. According to my comment, Tinkers-Defense (from 1.7.10) was the culprit. Apart from that, I don't remember much about this.