bug fixes #10
Merged
bug fixes #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import Intellisense for `<BottomSheet/>` uses deep component path `@devvie/bottom-sheet/lib/typescript/components/bottomSheet` instead of `@devvie/bottom-sheet`
passing an array to `style` prop causes typescript to complain because the `style` prop wasn't typed correctly. This commit fixes that.
…kPress` prop When `android_closeOnBackPress` is true, all pre-registered back press event listeners in the app is prevented from being called and `closeSheet` function is constantly closed even when sheet is closed. When it's false, it doesn't prevent sheet from being closed by back press. Fixes #9
…andle component setting padding properties (`padding`, `paddingLeft`, `paddingVetical`, etc) in the `style` prop causes the drag handle to move position in response to the paddings. This commit fixes that and also fixes a critical issue where padding styles also caused the sheet to have extruded height making it visible even when closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.