Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Pass changeresolution boolean to Patch method #9

Conversation

jonathonhillnz
Copy link
Contributor

@jonathonhillnz jonathonhillnz commented Jul 29, 2024

  • Updated Game.cs to call the correct overloaded Patch method with the changeresolution boolean.
  • Removed outdated TODO comment in AttributesFile.cs regarding the changeresolution checkbox.
  • Added logging in AttributesFile.cs to indicate whether the resolution is being changed based on the changeresolution flag.

These changes ensure that the checkbox state for changing resolution is correctly passed and handled, resulting in the appropriate behavior based on user input.

Issue #8

- Updated Game.cs to call the correct overloaded Patch method with the changeresolution boolean.
- Removed outdated TODO comment in AttributesFile.cs regarding the changeresolution checkbox.
- Added logging in AttributesFile.cs to indicate whether the resolution is being changed based on the changeresolution flag.

These changes ensure that the checkbox state for changing resolution is correctly passed and handled, resulting in the appropriate behavior based on user input.
@Bluscream Bluscream self-requested a review July 29, 2024 09:29
@Bluscream Bluscream self-assigned this Jul 29, 2024
@Bluscream Bluscream merged commit 815d401 into star-citizen-vr:csharp Nov 4, 2024
@Bluscream
Copy link
Member

Thanks for your contribution :) Sorry for the late merge :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants