add a basic test pair contract

[zuphitf]

This change is 

[codecov-commenter]

Codecov Report

Merging #972 (e679f5a) into main (2ced530) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #972   +/-   ##
=======================================
  Coverage   68.40%   68.40%           
=======================================
  Files          47       47           
  Lines        6024     6024           
  Branches     6024     6024           
=======================================
  Hits         4121     4121           
  Misses       1528     1528           
  Partials      375      375           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[dorimedini-starkware]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @zuphitf)

---

crates/blockifier/src/test_utils.rs line 294 at r1 (raw file):

        ((pair_address, reserve0_address), stark_felt!(RESERVE_0)),
        ((pair_address, reserve1_address), stark_felt!(RESERVE_1)),
    ]);

Please put this logic in a different state init function, it is not relevant for all tests... the address => class_hash mapping is fine, but this logic is a bit out of context here

pub fn deprecated_create_test_state_for_oracle_test() -> ... {
    let mut state = deprecated_create_test_state();
    ...
}

Code quote:

    // Override the pair's reserves data, since the constructor is not called.
    let pair_address = contract_address!(TEST_PAIR_SKELETON_CONTRACT_ADDRESS1);
    let reserve0_address = get_storage_var_address("_reserve0", &[]);
    let reserve1_address = get_storage_var_address("_reserve1", &[]);
    let storage_view = HashMap::from([
        ((pair_address, reserve0_address), stark_felt!(RESERVE_0)),
        ((pair_address, reserve1_address), stark_felt!(RESERVE_1)),
    ]);

[zuphitf]

crates/blockifier/src/test_utils.rs line 294 at r1 (raw file):

Previously, dorimedini-starkware wrote…

Please put this logic in a different state init function, it is not relevant for all tests... the address => class_hash mapping is fine, but this logic is a bit out of context here

pub fn deprecated_create_test_state_for_oracle_test() -> ... {
    let mut state = deprecated_create_test_state();
    ...
}

Moved to subfunctions like we discussed

[dorimedini-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @zuphitf)