-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: expend compile test #312
test: expend compile test #312
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on Graphite |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## arni/declare/compute_compiled_class_hash #312 +/- ##
============================================================================
+ Coverage 82.00% 83.38% +1.37%
============================================================================
Files 28 28
Lines 1423 1390 -33
Branches 1423 1390 -33
============================================================================
- Hits 1167 1159 -8
+ Misses 197 172 -25
Partials 59 59 ☔ View full report in Codecov by Sentry. |
f8db27c
to
358bcbd
Compare
84f8e88
to
0fc0a7c
Compare
358bcbd
to
dffdc5a
Compare
0fc0a7c
to
32940d4
Compare
dffdc5a
to
b12db17
Compare
32940d4
to
1680a36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @ArniStarkware)
crates/starknet_sierra_compile/src/test_utils.rs
line 37 at r1 (raw file):
// Ways to corrupt Sierra programs. pub fn trancate_sierra_program(sierra_program: &mut [BigUintAsHex]) -> Vec<BigUintAsHex> { let trancation_ammount = 100_usize;
Suggestion:
amount
crates/starknet_sierra_compile/src/test_utils.rs
line 50 at r1 (raw file):
sierra_program[modified_felt] = BigUintAsHex { value }; sierra_program.to_vec() }
back to the discussion of what are we testing here?
the cairo compilation code? or our own error handling code?
I think that for us only one type of error is enough. or maybe I'm missing something?
PR postponed. |
This change is