Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mempool): add error message in transaction queue #382

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

MohammadNassar1
Copy link
Contributor

@MohammadNassar1 MohammadNassar1 commented Jul 7, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.60%. Comparing base (025f4c3) to head (330f470).

Files Patch % Lines
crates/mempool/src/transaction_queue.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
- Coverage   83.69%   83.60%   -0.09%     
==========================================
  Files          37       37              
  Lines        1717     1720       +3     
  Branches     1717     1720       +3     
==========================================
+ Hits         1437     1438       +1     
- Misses        203      205       +2     
  Partials       77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)

@MohammadNassar1 MohammadNassar1 force-pushed the mohammad/transaction-queue/add-error-message branch 3 times, most recently from b811c88 to 47b6b35 Compare July 9, 2024 12:24
Copy link
Collaborator

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)

@MohammadNassar1 MohammadNassar1 force-pushed the mohammad/transaction-queue/add-error-message branch from 47b6b35 to 70ab8e2 Compare July 10, 2024 08:33
Copy link
Collaborator

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)

@MohammadNassar1 MohammadNassar1 force-pushed the mohammad/transaction-queue/add-error-message branch from 70ab8e2 to 330f470 Compare July 10, 2024 12:23
Copy link
Collaborator

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)

@MohammadNassar1 MohammadNassar1 merged commit 60ec73d into main Jul 10, 2024
8 checks passed
@MohammadNassar1 MohammadNassar1 deleted the mohammad/transaction-queue/add-error-message branch July 10, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants