refactor: move trace configuration to infra crate #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lev-starkware
force-pushed
the
pr/lev-starkware/lev_dev_main/cf4a80d3
branch
from
a99e157 to
042456e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
=======================================
Coverage 83.24% 83.24%
=======================================
Files 36 37 +1
Lines 1695 1695
Branches 1695 1695
=======================================
Hits 1411 1411
Misses 209 209
Partials 75 75 ☔ View full report in Codecov by Sentry. |
Itay-Tsabary-Starkware
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)
commit-id:cf4a80d3
lev-starkware
force-pushed
the
pr/lev-starkware/lev_dev_main/cf4a80d3
branch
from
042456e to
588108f
Compare
lev-starkware
commented
Jul 8, 2024
There was a problem hiding this comment.
Reviewed 3 of 6 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit-id:cf4a80d3
This change is