Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align config with python gateway #406

Merged

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Jul 8, 2024

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Jul 8, 2024

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.92%. Comparing base (5605a69) to head (7cbc692).

Files Patch % Lines
crates/gateway/src/config.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@                                  Coverage Diff                                  @@
##           arni/gateway/config/align_with_existing_default_1     #406      +/-   ##
=====================================================================================
+ Coverage                                              83.85%   83.92%   +0.07%     
=====================================================================================
  Files                                                     37       37              
  Lines                                                   1703     1711       +8     
  Branches                                                1703     1711       +8     
=====================================================================================
+ Hits                                                    1428     1436       +8     
  Misses                                                   200      200              
  Partials                                                  75       75              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry and @Yael-Starkware)

Copy link
Contributor Author

ArniStarkware commented Jul 9, 2024

Merge activity

@ArniStarkware ArniStarkware force-pushed the arni/gateway/config/align_with_existing_default_1 branch from 1663dd9 to 5605a69 Compare July 9, 2024 10:07
@ArniStarkware ArniStarkware force-pushed the arni/gateway/config/align_with_existing_default_2 branch from a8384f0 to 7cbc692 Compare July 9, 2024 10:26
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

@ArniStarkware ArniStarkware changed the base branch from arni/gateway/config/align_with_existing_default_1 to main July 10, 2024 08:58
@ArniStarkware ArniStarkware force-pushed the arni/gateway/config/align_with_existing_default_2 branch from 7cbc692 to 723ed87 Compare July 10, 2024 08:59
@ArniStarkware ArniStarkware merged commit 76462b2 into main Jul 10, 2024
8 checks passed
@ArniStarkware ArniStarkware deleted the arni/gateway/config/align_with_existing_default_2 branch August 21, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants