Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mempool): remove clone from transaction queue #414

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

MohammadNassar1
Copy link
Contributor

@MohammadNassar1 MohammadNassar1 commented Jul 9, 2024

This change is Reviewable

@MohammadNassar1 MohammadNassar1 requested a review from elintul July 9, 2024 11:22
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.37%. Comparing base (ea3e69d) to head (cd90f62).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   83.37%   83.37%           
=======================================
  Files          37       37           
  Lines        1720     1720           
  Branches     1720     1720           
=======================================
  Hits         1434     1434           
  Misses        210      210           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MohammadNassar1)

a discussion (no related file):
Thanks! Can you please make sure we don't have redundant #[derive(Clone)] anymore?


Copy link
Contributor Author

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul)

a discussion (no related file):

Previously, elintul (Elin) wrote…

Thanks! Can you please make sure we don't have redundant #[derive(Clone)] anymore?

In mempool crate files, we don't have anymore.


@MohammadNassar1 MohammadNassar1 merged commit 6e74e3f into main Jul 9, 2024
13 checks passed
@MohammadNassar1 MohammadNassar1 deleted the mohammad/transaction-queue/remove-clone branch July 9, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants