refactor(mempool): remove redandunt pub from account transaction inde… #423
Conversation
…s struct of tx pool
MohammadNassar1
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
=======================================
Coverage 83.54% 83.54%
=======================================
Files 37 37
Lines 1720 1720
Branches 1720 1720
=======================================
Hits 1437 1437
Misses 206 206
Partials 77 77 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @MohammadNassar1)
a discussion (no related file):
A suggestion for a more succinct commit message: "make AccountTransactionIndex API private".
crates/mempool/src/transaction_pool.rs line 76 at r1 (raw file):
#[derive(Debug, Default)] struct AccountTransactionIndex(HashMap<ContractAddress, BTreeMap<Nonce, TransactionReference>>);
No invariants on this mapping, it can be public.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @elintul)
crates/mempool/src/transaction_pool.rs line 76 at r1 (raw file):
Previously, elintul (Elin) wrote…
No invariants on this mapping, it can be
public.
The struct is private, so its methods cannot be accessed publicly.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @elintul)
a discussion (no related file):
Previously, elintul (Elin) wrote…
A suggestion for a more succinct commit message: "make AccountTransactionIndex API private".
Actually, I wanted to emphasize that it's redundant.
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)
…s struct of tx pool
This change is