Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set empty relative_path #495

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Jul 17, 2024

This change is Reviewable

@ArniStarkware ArniStarkware marked this pull request as ready for review July 17, 2024 11:22
Copy link
Contributor Author

ArniStarkware commented Jul 17, 2024

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.21%. Comparing base (fc5813a) to head (71013e9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #495   +/-   ##
=======================================
  Coverage   81.21%   81.21%           
=======================================
  Files          42       42           
  Lines        1826     1826           
  Branches     1826     1826           
=======================================
  Hits         1483     1483           
  Misses        269      269           
  Partials       74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

a discussion (no related file):
We need to make sure this is necessary.


@ArniStarkware ArniStarkware force-pushed the arni/chore/starknet_sierra_compile/fix_get_abs_path branch from b00b20b to 77398c0 Compare July 22, 2024 14:15
@ArniStarkware ArniStarkware changed the base branch from arni/chore/generalize_test_util to main July 22, 2024 14:16
@ArniStarkware ArniStarkware force-pushed the arni/chore/starknet_sierra_compile/fix_get_abs_path branch from 77398c0 to 71013e9 Compare July 23, 2024 14:03
@ArniStarkware ArniStarkware deleted the arni/chore/starknet_sierra_compile/fix_get_abs_path branch August 11, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants