Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_integration_tests): inherit sequencer node's stdout #2427

Conversation

alonh5
Copy link
Collaborator

@alonh5 alonh5 commented Dec 3, 2024

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

alonh5 commented Dec 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 7.63%. Comparing base (e3165c4) to head (5c072ac).
Report is 679 commits behind head on main.

Files with missing lines Patch % Lines
...rknet_sequencer_node/src/test_utils/compilation.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2427       +/-   ##
==========================================
- Coverage   40.10%   7.63%   -32.47%     
==========================================
  Files          26     231      +205     
  Lines        1895   25709    +23814     
  Branches     1895   25709    +23814     
==========================================
+ Hits          760    1964     +1204     
- Misses       1100   23669    +22569     
- Partials       35      76       +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@alonh5 alonh5 merged commit b409621 into main Dec 3, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants