feat(starknet_state_sync): implement state sync get latest block number

[noamsp-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[noamsp-starkware]

• feat(starknet_gateway): use sync state reader instead of rpc #2990
• feat(starknet_state_sync): implement state sync get latest block number #2944 👈 (View in Graphite)
• feat(starknet_gateway): implement sync state reader get block info #2942 : 1 other dependent PR (#2903 )
• fix(starknet_state_sync): verify contract deployed at get storage/nonce #2963 : 1 other dependent PR (#2886 )
• fix(starknet_state_sync): change marker verify from casm to state #2979
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ShahakShama]

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware)

---

crates/starknet_gateway/src/stateful_transaction_validator.rs line 138 at r1 (raw file):

    let state_reader = state_reader_factory.get_state_reader_from_latest_block().map_err(|e| {
        error!("Failed to get state reader from latest block: {}", e);
        GatewaySpecError::UnexpectedError { data: "Internal server error.".to_owned() }

Check this with @alonh5

[alonh5]

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @ShahakShama)

---

crates/starknet_gateway/src/stateful_transaction_validator.rs line 138 at r1 (raw file):

Previously, ShahakShama wrote…

Check this with @alonh5

This is fine. Didn't review the rest.

[ShahakShama]

Reviewed 5 of 7 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware)

---

crates/starknet_gateway/src/sync_state_reader.rs line 121 at r3 (raw file):

impl StateReaderFactory for SyncStateReaderFactory {
    fn get_state_reader_from_latest_block(&self) -> StateResult<Box<dyn MempoolStateReader>> {

No reason to use StateResult. You can use StateSyncResult instead

[noamsp-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ShahakShama)

---

crates/starknet_gateway/src/sync_state_reader.rs line 121 at r3 (raw file):

Previously, ShahakShama wrote…

No reason to use StateResult. You can use StateSyncResult instead

StateReaderFactory defines this return value.

[ShahakShama]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware)

---

crates/starknet_gateway/src/sync_state_reader.rs line 121 at r3 (raw file):

Previously, noamsp-starkware wrote…

StateReaderFactory defines this return value.

This just means that I put the comment on the wrong file. Fix it where you define StateReaderFactory

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-31T08:08:39Z

[noamsp-starkware]

Reviewable status: 2 of 8 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @ShahakShama)

---

crates/starknet_gateway/src/sync_state_reader.rs line 121 at r3 (raw file):

Previously, ShahakShama wrote…

This just means that I put the comment on the wrong file. Fix it where you define StateReaderFactory

Done.

[ShahakShama]

Reviewed 6 of 6 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)