Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(starknet_batcher): fee market documentation reshape #2964

Merged

Conversation

ayeletstarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ayeletstarkware ayeletstarkware force-pushed the ayelet/batcher/fee_market/documantation-rephase branch from 710c5b4 to 40ec2b7 Compare December 25, 2024 15:14
Copy link
Contributor

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware)

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware)


crates/starknet_batcher/src/fee_market.rs line 20 at r1 (raw file):

/// - `price`: Base gas price per unit (in FRI) of the current block.
/// - `gas_used`: Total gas used by all transactions in the block.
/// - `gas_target`: Target gas usage per block (usually half of the block's gas limit).

I like these two additions you made. Other than that, I would leave it as it was.

Suggestion:

/// - `price`: The base gas price per unit (in fri) of the current block.
/// - `gas_used`: The total gas used in the current block.
/// - `gas_target`: The target gas usage per block (usually half of a block's gas limit).

@ayeletstarkware ayeletstarkware force-pushed the ayelet/batcher/fee_market/documantation-rephase branch from 40ec2b7 to f9d0d58 Compare December 26, 2024 09:49
Copy link
Contributor Author

@ayeletstarkware ayeletstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @MohammadNassar1)


crates/starknet_batcher/src/fee_market.rs line 20 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

I like these two additions you made. Other than that, I would leave it as it was.

Done.

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware)

@ayeletstarkware ayeletstarkware added this pull request to the merge queue Dec 26, 2024
Merged via the queue into main with commit 29d16de Dec 26, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants