-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(starknet_batcher): fee market documentation reshape #2964
refactor(starknet_batcher): fee market documentation reshape #2964
Conversation
710c5b4
to
40ec2b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware)
crates/starknet_batcher/src/fee_market.rs
line 20 at r1 (raw file):
/// - `price`: Base gas price per unit (in FRI) of the current block. /// - `gas_used`: Total gas used by all transactions in the block. /// - `gas_target`: Target gas usage per block (usually half of the block's gas limit).
I like these two additions you made. Other than that, I would leave it as it was.
Suggestion:
/// - `price`: The base gas price per unit (in fri) of the current block.
/// - `gas_used`: The total gas used in the current block.
/// - `gas_target`: The target gas usage per block (usually half of a block's gas limit).
40ec2b7
to
f9d0d58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @MohammadNassar1)
crates/starknet_batcher/src/fee_market.rs
line 20 at r1 (raw file):
Previously, alonh5 (Alon Haramati) wrote…
I like these two additions you made. Other than that, I would leave it as it was.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware)
No description provided.