refactor(consensus): move fee_market to concensus

[ayeletstarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ayeletstarkware]

• refactor(consensus): move fee_market to concensus #2977 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[alonh5]

Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ayeletstarkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/lib.rs line 15 at r2 (raw file):

pub mod cende;

/// Fee market logic.

No need if it's just repeating the name of the module.

Code quote:

/// Fee market logic.

---

crates/sequencing/papyrus_consensus_orchestrator/src/lib.rs line 16 at r2 (raw file):

/// Fee market logic.
#[allow(missing_docs)]

What is this?

Code quote:

#[allow(missing_docs)]

---

crates/sequencing/papyrus_consensus_orchestrator/src/fee_market_logic/mod.rs line 1 at r2 (raw file):

pub mod fee_market;

The module is fee_market_logic, no need to declare another module here.
Also, move all the content of fee_market.rs here. You can rename fee_market_logic -> fee_market.

[ayeletstarkware]

Reviewable status: 1 of 5 files reviewed, 3 unresolved discussions (waiting on @alonh5)

---

crates/sequencing/papyrus_consensus_orchestrator/src/lib.rs line 15 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

No need if it's just repeating the name of the module.

if we leave this documention we can remove the #[allow(missing_docs)], so I left it. do you prefer I add more info about this module?

---

crates/sequencing/papyrus_consensus_orchestrator/src/lib.rs line 16 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

What is this?

answered above

---

crates/sequencing/papyrus_consensus_orchestrator/src/fee_market_logic/mod.rs line 1 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

The module is fee_market_logic, no need to declare another module here.
Also, move all the content of fee_market.rs here. You can rename fee_market_logic -> fee_market.

Done.

[alonh5]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/lib.rs line 15 at r2 (raw file):

Previously, ayeletstarkware (Ayelet Zilber) wrote…

if we leave this documention we can remove the #[allow(missing_docs)], so I left it. do you prefer I add more info about this module?

This is fine in that case. Can you remove the #[allow(missing_docs)] from cende also?

[ayeletstarkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/lib.rs line 15 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

This is fine in that case. Can you remove the #[allow(missing_docs)] from cende also?

I tried to, but more documentation is needed there (in cende/mod.rs).