Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: define sierra to casm compiler trait #319

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 5, 2024

This change is Reviewable

@ArniStarkware ArniStarkware changed the title WIP. refactor: define sierra to casm compiler trait Aug 5, 2024
@ArniStarkware ArniStarkware marked this pull request as ready for review August 5, 2024 08:30
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from f06bbeb to 33ea51c Compare August 5, 2024 14:12
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from 5c54749 to 5dcbcde Compare August 5, 2024 14:12
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from 33ea51c to f9dd325 Compare August 6, 2024 11:22
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from 5dcbcde to d27096d Compare August 6, 2024 11:22
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from f9dd325 to bb73e86 Compare August 6, 2024 12:08
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from d27096d to 6bc1920 Compare August 6, 2024 12:08
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArniStarkware, @Yael-Starkware, and @yair-starkware)


crates/starknet_sierra_compile/src/compile.rs line 18 at r1 (raw file):

/// `cairo_lang_starknet_classes` crate.
#[derive(Clone)]
pub struct CairoLangCompiler {

Suggestion:

CairoLangSierraToCasmCompiler

crates/starknet_sierra_compile/src/lib.rs line 16 at r1 (raw file):

pub trait SierraToCasmCompiler: Send + Sync {
    fn compile_sierra_to_casm(

Suggestion:

compile

@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from bb73e86 to 2007594 Compare August 6, 2024 14:02
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from 6bc1920 to 4073878 Compare August 6, 2024 14:02
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from 2007594 to 7301e68 Compare August 6, 2024 14:36
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from 4073878 to c0a8510 Compare August 6, 2024 14:36
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from 7301e68 to 47853d8 Compare August 7, 2024 05:14
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from c0a8510 to a0d2098 Compare August 7, 2024 05:14
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from 47853d8 to dc09147 Compare August 7, 2024 07:02
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from a0d2098 to 636aeaf Compare August 7, 2024 07:02
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 8 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry, @Yael-Starkware, and @yair-starkware)


crates/starknet_sierra_compile/src/compile.rs line 18 at r1 (raw file):

/// `cairo_lang_starknet_classes` crate.
#[derive(Clone)]
pub struct CairoLangCompiler {

Done.


crates/starknet_sierra_compile/src/lib.rs line 16 at r1 (raw file):

pub trait SierraToCasmCompiler: Send + Sync {
    fn compile_sierra_to_casm(

Done.

@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from dc09147 to 94b3990 Compare August 7, 2024 07:06
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from 636aeaf to 4bf529f Compare August 7, 2024 07:06
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware and @yair-starkware)

Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware and @yair-starkware)

@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from 94b3990 to 8bd0c70 Compare August 7, 2024 10:29
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from 4bf529f to 57ba7f0 Compare August 7, 2024 10:29
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from 8bd0c70 to b5e6627 Compare August 7, 2024 12:06
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from 57ba7f0 to 2c2df79 Compare August 7, 2024 12:06
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from b5e6627 to b2cbef7 Compare August 7, 2024 12:52
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from 2c2df79 to 200dae4 Compare August 7, 2024 12:52
Copy link
Contributor Author

ArniStarkware commented Aug 8, 2024

Merge activity

@ArniStarkware ArniStarkware changed the base branch from arni/declare/compilation/move_catch_into_util to graphite-base/319 August 8, 2024 09:49
@ArniStarkware ArniStarkware changed the base branch from graphite-base/319 to main August 8, 2024 09:55
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from 200dae4 to 620c570 Compare August 8, 2024 09:56
@ArniStarkware ArniStarkware merged commit 2b65030 into main Aug 8, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
@ArniStarkware ArniStarkware deleted the arni/declare/compilation/hide_behind/trait branch August 13, 2024 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants