-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: define sierra to casm compiler trait #319
Conversation
f06bbeb
to
33ea51c
Compare
5c54749
to
5dcbcde
Compare
33ea51c
to
f9dd325
Compare
5dcbcde
to
d27096d
Compare
f9dd325
to
bb73e86
Compare
d27096d
to
6bc1920
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArniStarkware, @Yael-Starkware, and @yair-starkware)
crates/starknet_sierra_compile/src/compile.rs
line 18 at r1 (raw file):
/// `cairo_lang_starknet_classes` crate. #[derive(Clone)] pub struct CairoLangCompiler {
Suggestion:
CairoLangSierraToCasmCompiler
crates/starknet_sierra_compile/src/lib.rs
line 16 at r1 (raw file):
pub trait SierraToCasmCompiler: Send + Sync { fn compile_sierra_to_casm(
Suggestion:
compile
bb73e86
to
2007594
Compare
6bc1920
to
4073878
Compare
2007594
to
7301e68
Compare
4073878
to
c0a8510
Compare
7301e68
to
47853d8
Compare
c0a8510
to
a0d2098
Compare
47853d8
to
dc09147
Compare
a0d2098
to
636aeaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 8 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry, @Yael-Starkware, and @yair-starkware)
crates/starknet_sierra_compile/src/compile.rs
line 18 at r1 (raw file):
/// `cairo_lang_starknet_classes` crate. #[derive(Clone)] pub struct CairoLangCompiler {
Done.
crates/starknet_sierra_compile/src/lib.rs
line 16 at r1 (raw file):
pub trait SierraToCasmCompiler: Send + Sync { fn compile_sierra_to_casm(
Done.
dc09147
to
94b3990
Compare
636aeaf
to
4bf529f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware and @yair-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware and @yair-starkware)
94b3990
to
8bd0c70
Compare
4bf529f
to
57ba7f0
Compare
8bd0c70
to
b5e6627
Compare
57ba7f0
to
2c2df79
Compare
b5e6627
to
b2cbef7
Compare
2c2df79
to
200dae4
Compare
Merge activity
|
200dae4
to
620c570
Compare
This change is