feat: use the command line compiler in gateway

[ArniStarkware]

This change is 

[ArniStarkware]

• feat: use the command line compiler in gateway #599 👈
• feat: use the starknet-sierra-compile downloaded binary to compile #598
• feat: use the build script to download the cairo crate from the starkware release page #597
• chore: streamline the error types in starknet_sierra_compile crate #566 : 2 other dependent PRs (#331 , #581 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.49%. Comparing base (d1aa365) to head (7868f5c).
Report is 6 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #599       +/-   ##
===========================================
- Coverage   76.62%   28.49%   -48.14%     
===========================================
  Files         351      209      -142     
  Lines       37223    23945    -13278     
  Branches    37223    23945    -13278     
===========================================
- Hits        28522     6823    -21699     
- Misses       6388    16375     +9987     
+ Partials     2313      747     -1566     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dafnamatsry]

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ArniStarkware)

---

crates/gateway/build.rs line 1 at r1 (raw file):

// Sets up the environment variable OUT_DIR.

Suggestion:

// Sets up the environment variable OUT_DIR, which holds the cairo compiler binary.
// The binary is dowloaded to OUT_DIR by the starknet_sierra_compile crate.

---

crates/gateway/src/stateful_transaction_validator_test.rs line 85 at r1 (raw file):

    stateful_validator: StatefulTransactionValidator,
) {
    let optional_class_info =

Can you add the optional_class_info as a case argument and set it to None?
i.e.:

Suggestion:

#[case::invalid_tx(invoke_tx(CairoVersion::Cairo1), Err(STATEFUL_VALIDATOR_FEE_ERROR)), None]
fn test_stateful_tx_validator(
    #[case] external_tx: RpcTransaction,
    #[case] expected_result: BlockifierStatefulValidatorResult<ValidateInfo>,
    #[case] class_info: Option<ClassInfo>,
    stateful_validator: StatefulTransactionValidator,
) {

---

crates/tests-integration/build.rs line 2 at r1 (raw file):

// Sets up the environment variable OUT_DIR. This is necessary for for the crate
// starknet_sierra_compile.

Suggestion:

// Sets up the environment variable OUT_DIR. This is necessary for for the crate
// starknet_sierra_compile to download the cairo compiler binary.

[ArniStarkware]

Reviewable status: 3 of 7 files reviewed, 3 unresolved discussions (waiting on @dafnamatsry)

---

crates/gateway/build.rs line 1 at r1 (raw file):

// Sets up the environment variable OUT_DIR.

Done.

---

crates/gateway/src/stateful_transaction_validator_test.rs line 85 at r1 (raw file):

Previously, dafnamatsry wrote…

Can you add the optional_class_info as a case argument and set it to None?
i.e.:

Done.
Even better.

---

crates/tests-integration/build.rs line 2 at r1 (raw file):

// Sets up the environment variable OUT_DIR. This is necessary for for the crate
// starknet_sierra_compile.

Done.

[dafnamatsry]

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[dafnamatsry]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[ArniStarkware]

Merge activity

• Sep 3, 2:07 AM EDT: @ArniStarkware started a stack merge that includes this pull request via Graphite.
• Sep 3, 2:21 AM EDT: Graphite rebased this pull request as part of a merge.
• Sep 3, 2:27 AM EDT: @ArniStarkware merged this pull request with Graphite.