-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
87 autogeneration #88
base: master
Are you sure you want to change the base?
Conversation
for starknet_trace_api :
--> infinite loop :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @notV4l)
api/starknet_write_api.json
line 145 at r1 (raw file):
"$ref": "./api/starknet_api_openrpc.json#/components/schemas/FUNCTION_CALL" }, "SIERRA_ENTRY_POINT": {
why do we need all the new references in the write API?
i was not able to validate / generate types files without this changes there is still issues to generate types for the trace_api (infinite loop) |
Infinite loop is from recursive reference: FUNCTION_INVOCATION -> calls -> NESTED_CALL -> FUNCTION_INVOCATION ... |
rel : #87
fix validation error on starknet_write_api
fix issues for generating typings for starknet_write_api
do not fix issues for generating typings for starknet_trace_api :
i suspect oneOf / allOf to create infinite loop while generating typings