Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize addLeadingZeroes function #18

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

nir11
Copy link
Contributor

@nir11 nir11 commented Aug 22, 2023

Description of the Changes

Utilized padStart instead of a string concatenation loop for a more concise & efficient code.

Check List

  • Changes have been done against master branch, and PR does not conflict
  • New unit / functional tests have been added (whenever applicable)
  • Test are passing in local environment
  • Docs have been updated
  • PR title is follow the convention: <type>[optional scope]: <description>, e.g: fix: minor typos in code

@dan-ziv dan-ziv self-requested a review November 14, 2023 11:49
dan-ziv
dan-ziv previously approved these changes Nov 14, 2023
@dan-ziv dan-ziv closed this Nov 14, 2023
@dan-ziv dan-ziv reopened this Nov 14, 2023
@dan-ziv dan-ziv merged commit d2eb73b into starkware-libs:dev Nov 14, 2023
6 checks passed
@dan-ziv
Copy link
Collaborator

dan-ziv commented Nov 14, 2023

🎉 This PR is included in version 0.2.1-dev.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Cevedale
Copy link

let's go!

@dan-ziv
Copy link
Collaborator

dan-ziv commented Nov 15, 2023

🎉 This PR is included in version 0.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants