Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added run_and_prove binary #227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yuvalsw
Copy link
Collaborator

@yuvalsw yuvalsw commented Dec 3, 2024

(and refactorred binaries to share code)


This change is Reviewable

(and refactorred binaries to share code)
Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @yuvalsw)


a discussion (no related file):
Why we need to create another crate and not create two binaries from the same one?


stwo_cairo_prover/crates/vm_runner/src/main.rs line 24 at r1 (raw file):

    vm_args: VmArgs,
    #[structopt(long = "output_path")]
    output_path: PathBuf,

What is special about this attribute?

Code quote:

    #[structopt(long = "output_path")]
    output_path: PathBuf,

stwo_cairo_prover/crates/vm_runner/src/main.rs line 34 at r1 (raw file):

    IO(#[from] std::io::Error),
    #[error("VM run failed: {0}")]
    Vm(#[from] VmError),

This means that now we will get Error::VM::IO
Is this the resulted behaviour? (should we test those things?)

Code quote:

Vm(#[from] VmError),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants