add adapter tests

[Stavbe]

Add a unit test to ensure instructions are correctly mapped with the adapter.
The only components that can’t be tested using casm! are:

jmp rel [ap/fp + offset]
jump abs [[ap/fp + offset1] + offset2]
[ap/fp + offset0] = [[ap/fp + offset1] + offset

---

This change is 

[ohad-starkware]

so double derefs? doc that somewhere

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @Stavbe)

[ohad-starkware]

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @Stavbe)

---

stwo_cairo_prover/crates/prover/src/input/state_transitions.rs line 641 at r3 (raw file):

// Ensures that instructions are correctly mapped with the adapter.
// All components were checked except:

this needs to be a TODO

---

stwo_cairo_prover/crates/prover/src/input/state_transitions.rs line 1030 at r3 (raw file):

        let input = input_from_plain_casm(instructions, false);
        let casm_states_by_opcode = input.state_transitions.casm_states_by_opcode;
        println!("{:?}", casm_states_by_opcode.counts());

remove

[Stavbe]

Added

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @ohad-starkware and @Stavbe)

---

stwo_cairo_prover/crates/prover/src/input/state_transitions.rs line 641 at r3 (raw file):

Previously, ohad-starkware (Ohad) wrote…

this needs to be a TODO

We won't be able to test those using the same terminology because the casm macro does not support it, and according to Ori Ziv, it will not be expanded to support it.

---

stwo_cairo_prover/crates/prover/src/input/state_transitions.rs line 1030 at r3 (raw file):

Previously, ohad-starkware (Ohad) wrote…

remove

Done.

[ohad-starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Stavbe)

---

stwo_cairo_prover/crates/prover/src/input/state_transitions.rs line 641 at r3 (raw file):

Previously, Stavbe wrote…

We won't be able to test those using the same terminology because the casm macro does not support it, and according to Ori Ziv, it will not be expanded to support it.

still a todo

[Stavbe]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Stavbe)

---

stwo_cairo_prover/crates/prover/src/input/state_transitions.rs line 641 at r3 (raw file):

Previously, ohad-starkware (Ohad) wrote…

still a todo

todo what ?

[Stavbe]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware and @Stavbe)

---

stwo_cairo_prover/crates/prover/src/input/state_transitions.rs line 641 at r3 (raw file):

Previously, Stavbe wrote…

todo what ?

Done.

[ohad-starkware]

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @Stavbe)

---

stwo_cairo_prover/crates/prover/src/input/state_transitions.rs line 644 at r5 (raw file):

}

// Ensures that instructions are correctly mapped with the adapter.

Suggestion:

/// Tests instructions mapping.

---

stwo_cairo_prover/crates/prover/src/input/state_transitions.rs line 645 at r5 (raw file):

// Ensures that instructions are correctly mapped with the adapter.
// All components were checked except:

Suggestion:

/// Every opcode is tested except:

---

stwo_cairo_prover/crates/prover/src/input/state_transitions.rs line 650 at r5 (raw file):

// TODO(Stav): Find a way to check those without the casm macro.
#[cfg(test)]
mod tests {

Suggestion:

mod mappings_tests

[Stavbe]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @ohad-starkware and @Stavbe)

---

stwo_cairo_prover/crates/prover/src/input/state_transitions.rs line 644 at r5 (raw file):

}

// Ensures that instructions are correctly mapped with the adapter.

Done.

---

stwo_cairo_prover/crates/prover/src/input/state_transitions.rs line 645 at r5 (raw file):

// Ensures that instructions are correctly mapped with the adapter.
// All components were checked except:

Done.

[ohad-starkware]

Reviewed 1 of 2 files at r5.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @Stavbe)

---

stwo_cairo_prover/crates/prover/src/input/vm_import/mod.rs line 215 at r6 (raw file):

        // TODO(Ohad): update counts after adding mull small.
        assert_eq!(components.mul_opcode_is_small_t_is_imm_t.len(), 0);
        assert_eq!(components.mul_opcode_is_small_t_is_imm_f.len(), 0);

can dev mode be turned off here and revert that?

[Stavbe]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware and @Stavbe)

---

stwo_cairo_prover/crates/prover/src/input/vm_import/mod.rs line 215 at r6 (raw file):

Previously, ohad-starkware (Ohad) wrote…

can dev mode be turned off here and revert that?

Done.