Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify batched logup #249

Merged
merged 1 commit into from
Dec 17, 2024
Merged

verify batched logup #249

merged 1 commit into from
Dec 17, 2024

Conversation

ohad-starkware
Copy link
Contributor

@ohad-starkware ohad-starkware commented Dec 15, 2024

This change is Reviewable

This was referenced Dec 15, 2024
Copy link
Contributor Author

ohad-starkware commented Dec 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

Copy link
Contributor Author

ohad-starkware commented Dec 17, 2024

Merge activity

  • Dec 17, 4:12 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 17, 4:20 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 17, 4:26 AM EST: A user merged this pull request with Graphite.

@ohad-starkware ohad-starkware changed the base branch from memory_batched_logup to graphite-base/249 December 17, 2024 09:13
@ohad-starkware ohad-starkware changed the base branch from graphite-base/249 to main December 17, 2024 09:18
@ohad-starkware ohad-starkware merged commit b407d46 into main Dec 17, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants