Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganize folders. #253

Merged
merged 1 commit into from
Dec 17, 2024
Merged

reorganize folders. #253

merged 1 commit into from
Dec 17, 2024

Conversation

ilyalesokhin-starkware
Copy link
Collaborator

@ilyalesokhin-starkware ilyalesokhin-starkware commented Dec 16, 2024

This change is Reviewable

Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 33 of 33 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)


stwo_cairo_verifier/crates/verifier_core/Scarb.lock line 0 at r1 (raw file):
How come that the lock is empty?
Do we want to commit that?

Copy link
Collaborator Author

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)


stwo_cairo_verifier/crates/verifier_core/Scarb.lock line at r1 (raw file):

Previously, shaharsamocha7 wrote…

How come that the lock is empty?
Do we want to commit that?

removed, thanks.

@ilyalesokhin-starkware ilyalesokhin-starkware merged commit 4de4d1d into main Dec 17, 2024
5 of 6 checks passed
@ilyalesokhin-starkware ilyalesokhin-starkware deleted the ilya/reorg branch December 17, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants