Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated toolchain #264

Merged
merged 1 commit into from
Dec 19, 2024
Merged

updated toolchain #264

merged 1 commit into from
Dec 19, 2024

Conversation

ohad-starkware
Copy link
Contributor

@ohad-starkware ohad-starkware commented Dec 18, 2024

This change is Reviewable

Copy link
Contributor Author

ohad-starkware commented Dec 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ohad-starkware ohad-starkware force-pushed the ohad/update_toolchain_12_16 branch 2 times, most recently from 3b9c330 to 0453c8a Compare December 18, 2024 17:08
@ohad-starkware ohad-starkware self-assigned this Dec 18, 2024
@ohad-starkware ohad-starkware force-pushed the ohad/update_toolchain_12_16 branch from 0453c8a to 583ece2 Compare December 18, 2024 17:17
@ohad-starkware ohad-starkware force-pushed the ohad/update_toolchain_12_16 branch from 583ece2 to 163adab Compare December 19, 2024 06:28
Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 12 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @ohad-starkware)


stwo_cairo_prover/scripts/rust_fmt.sh line 3 at r2 (raw file):

#!/bin/bash

cargo fmt --all -- "$@"

same

Code quote:

cargo fmt --all -- "$@"

stwo_cairo_prover/scripts/clippy.sh line 4 at r2 (raw file):

cargo clippy "$@" --all-targets --all-features -- -D warnings \
    -D future-incompatible -D nonstandard-style -D rust-2018-idioms -D unused

Write the version explicitly

Suggestion:

cargo +nightly-2024-12-16 clippy "$@" --all-targets --all-features -- -D warnings \
    -D future-incompatible -D nonstandard-style -D rust-2018-idioms -D unused

Copy link
Contributor Author

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @shaharsamocha7)


stwo_cairo_prover/scripts/clippy.sh line 4 at r2 (raw file):

Previously, shaharsamocha7 wrote…

Write the version explicitly

it's derived from the version stated in rust-toolchain
I think it is more stable to not re mention it here again

This was referenced Dec 19, 2024
Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

@ohad-starkware ohad-starkware merged commit 53c4ea9 into main Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants