-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated toolchain #264
updated toolchain #264
Conversation
3b9c330
to
0453c8a
Compare
0453c8a
to
583ece2
Compare
583ece2
to
163adab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 12 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @ohad-starkware)
stwo_cairo_prover/scripts/rust_fmt.sh
line 3 at r2 (raw file):
#!/bin/bash cargo fmt --all -- "$@"
same
Code quote:
cargo fmt --all -- "$@"
stwo_cairo_prover/scripts/clippy.sh
line 4 at r2 (raw file):
cargo clippy "$@" --all-targets --all-features -- -D warnings \ -D future-incompatible -D nonstandard-style -D rust-2018-idioms -D unused
Write the version explicitly
Suggestion:
cargo +nightly-2024-12-16 clippy "$@" --all-targets --all-features -- -D warnings \
-D future-incompatible -D nonstandard-style -D rust-2018-idioms -D unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @shaharsamocha7)
stwo_cairo_prover/scripts/clippy.sh
line 4 at r2 (raw file):
Previously, shaharsamocha7 wrote…
Write the version explicitly
it's derived from the version stated in rust-toolchain
I think it is more stable to not re mention it here again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
This change is