-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first point rc constraint. #33
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @shaharsamocha7)
stwo_cairo_prover/src/components/memory/component.rs
line 238 at r1 (raw file):
vec![point, point - domain.step().into_ef()]; SECURE_EXTENSION_DEGREE ]);
I think this can look a bit better.
Suggestion:
let step = domain.step().into_ef();
let mut interaction_points =
chain!(
[vec![point, point - step]; SECURE_EXTENSION_DEGREE],
[vec![point]; SECURE_EXTENSION_DEGREE * (N_M31_IN_FELT252 - 1)],
[vec![point, point - step]; SECURE_EXTENSION_DEGREE]
]);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @alonh5 and @shaharsamocha7)
stwo_cairo_prover/src/components/memory/component.rs
line 238 at r1 (raw file):
vec![point, point - domain.step().into_ef()]; SECURE_EXTENSION_DEGREE ]);
We would like to aggregate all sums together
5158a31
to
89be00f
Compare
8df0f4c
to
d1a2323
Compare
89be00f
to
7043048
Compare
d1a2323
to
d4fd006
Compare
7043048
to
4be740f
Compare
d4fd006
to
ededd65
Compare
This change is