-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark script #408
benchmark script #408
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
a discussion (no related file):
How can we check that it runs in the CI?
It should only work if the machine has avx512 support right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)
a discussion (no related file):
Previously, shaharsamocha7 wrote…
How can we check that it runs in the CI?
It should only work if the machine has avx512 support right?
Right now it's not in the CI. I just added the script so that everyione will know the right flags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
a discussion (no related file):
Previously, spapinistarkware (Shahar Papini) wrote…
Right now it's not in the CI. I just added the script so that everyione will know the right flags
so we use it as ./script/bench.sh "bench_name"?
Can you add a usage example as a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @shaharsamocha7)
a discussion (no related file):
Previously, shaharsamocha7 wrote…
so we use it as ./script/bench.sh "bench_name"?
Can you add a usage example as a comment
Yes.
75d42fe
to
87a530e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)
This change is