Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark script #408

Merged
merged 1 commit into from
Feb 26, 2024
Merged

benchmark script #408

merged 1 commit into from
Feb 26, 2024

Conversation

spapinistarkware
Copy link
Contributor

@spapinistarkware spapinistarkware commented Feb 26, 2024

This change is Reviewable

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)

a discussion (no related file):
How can we check that it runs in the CI?
It should only work if the machine has avx512 support right?


Copy link
Contributor Author

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)

a discussion (no related file):

Previously, shaharsamocha7 wrote…

How can we check that it runs in the CI?
It should only work if the machine has avx512 support right?

Right now it's not in the CI. I just added the script so that everyione will know the right flags


Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved

a discussion (no related file):

Previously, spapinistarkware (Shahar Papini) wrote…

Right now it's not in the CI. I just added the script so that everyione will know the right flags

so we use it as ./script/bench.sh "bench_name"?
Can you add a usage example as a comment


Copy link
Contributor Author

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @shaharsamocha7)

a discussion (no related file):

Previously, shaharsamocha7 wrote…

so we use it as ./script/bench.sh "bench_name"?
Can you add a usage example as a comment

Yes.


@spapinistarkware spapinistarkware force-pushed the spapini/02-26-benchmark_script branch from 75d42fe to 87a530e Compare February 26, 2024 10:16
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

@spapinistarkware spapinistarkware merged commit 3a7c108 into dev Feb 26, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants