Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create proofs for Cairo #899

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Conversation

andrewmilson
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

andrewmilson commented Nov 25, 2024

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 90ff535 Previous: cd8b37b Ratio
iffts/simd ifft/21 6194778 ns/iter (± 189986) 3044114 ns/iter (± 156865) 2.04
iffts/simd ifft/22 13771194 ns/iter (± 174874) 6306399 ns/iter (± 210024) 2.18
iffts/simd ifft/23 30311458 ns/iter (± 2122076) 15132449 ns/iter (± 291195) 2.00
iffts/simd ifft/25 135586882 ns/iter (± 1844837) 65891527 ns/iter (± 1735211) 2.06
iffts/simd ifft/26 278987670 ns/iter (± 6523410) 136655216 ns/iter (± 2242165) 2.04
iffts/simd ifft/27 646887558 ns/iter (± 21397852) 312588285 ns/iter (± 9816879) 2.07
iffts/simd ifft/28 1303341903 ns/iter (± 25042426) 643771030 ns/iter (± 19147376) 2.02
simd rfft 20bit 3274458 ns/iter (± 70274) 1617070 ns/iter (± 66435) 2.02
merkle throughput/simd merkle 31521402 ns/iter (± 1137395) 13712527 ns/iter (± 579195) 2.30

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Base automatically changed from Commit_fri_first_layer to dev November 25, 2024 13:30
@andrewmilson andrewmilson force-pushed the 11-23-Create_proofs_for_Cairo branch from cb5c34a to 90ff535 Compare November 28, 2024 13:30
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 32 lines in your changes missing coverage. Please review.

Project coverage is 90.94%. Comparing base (af9250e) to head (90ff535).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
crates/prover/src/core/fri.rs 77.62% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #899      +/-   ##
==========================================
- Coverage   91.77%   90.94%   -0.84%     
==========================================
  Files          93       93              
  Lines       13282    13630     +348     
  Branches    13282    13630     +348     
==========================================
+ Hits        12190    12396     +206     
- Misses        979     1123     +144     
+ Partials      113      111       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants