-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
relation tracker #909
relation tracker #909
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #909 +/- ##
==========================================
- Coverage 91.69% 90.96% -0.73%
==========================================
Files 93 94 +1
Lines 13164 13486 +322
Branches 13164 13486 +322
==========================================
+ Hits 12071 12268 +197
- Misses 980 1107 +127
+ Partials 113 111 -2 ☔ View full report in Codecov by Sentry. |
6e61255
to
2e99afb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2
.
Benchmark suite | Current: b4fefbf | Previous: cd8b37b | Ratio |
---|---|---|---|
iffts/simd ifft/22 |
12882287 ns/iter (± 168474 ) |
6306399 ns/iter (± 210024 ) |
2.04 |
merkle throughput/simd merkle |
31097667 ns/iter (± 322403 ) |
13712527 ns/iter (± 579195 ) |
2.27 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @shaharsamocha7
d0559f6
to
7fd1e73
Compare
7fd1e73
to
b4fefbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 5 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ohad-starkware and @shaharsamocha7)
crates/prover/src/core/pcs/utils.rs
line 44 at r3 (raw file):
} /// Converts `&TreeVec<&Vec<T>>` to `TreeVec<Vec<&T>>`.
Thank you! I needed this like 3 times and was always too lazy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alon-Ti and @shaharsamocha7)
crates/prover/src/core/pcs/utils.rs
line 44 at r3 (raw file):
Previously, Alon-Ti wrote…
Thank you! I needed this like 3 times and was always too lazy.
no problem bud
macro export (#900)
Commit to FRI first layer (#897)
Exported shared code to temp variables in ExprEvaluator. (#893)
relation tracker