Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relation tracker #909

Merged
merged 1 commit into from
Dec 2, 2024
Merged

relation tracker #909

merged 1 commit into from
Dec 2, 2024

Conversation

ohad-starkware
Copy link
Collaborator

macro export (#900)

Commit to FRI first layer (#897)

Exported shared code to temp variables in ExprEvaluator. (#893)

relation tracker

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

ohad-starkware commented Nov 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 120 lines in your changes missing coverage. Please review.

Project coverage is 90.96%. Comparing base (4d64300) to head (b4fefbf).
Report is 11 commits behind head on dev.

Files with missing lines Patch % Lines
...rover/src/constraint_framework/relation_tracker.rs 0.00% 117 Missing ⚠️
crates/prover/src/core/pcs/utils.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #909      +/-   ##
==========================================
- Coverage   91.69%   90.96%   -0.73%     
==========================================
  Files          93       94       +1     
  Lines       13164    13486     +322     
  Branches    13164    13486     +322     
==========================================
+ Hits        12071    12268     +197     
- Misses        980     1107     +127     
+ Partials      113      111       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ohad-starkware ohad-starkware changed the title macro export (#900) relation trackler Nov 27, 2024
@ohad-starkware ohad-starkware changed the title relation trackler relation tracker Nov 27, 2024
@ohad-starkware ohad-starkware self-assigned this Nov 27, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: b4fefbf Previous: cd8b37b Ratio
iffts/simd ifft/22 12882287 ns/iter (± 168474) 6306399 ns/iter (± 210024) 2.04
merkle throughput/simd merkle 31097667 ns/iter (± 322403) 13712527 ns/iter (± 579195) 2.27

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

@ohad-starkware ohad-starkware force-pushed the ohad/relationeval branch 2 times, most recently from d0559f6 to 7fd1e73 Compare November 28, 2024 11:33
This was referenced Nov 28, 2024
Copy link
Contributor

@Alon-Ti Alon-Ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 5 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ohad-starkware and @shaharsamocha7)


crates/prover/src/core/pcs/utils.rs line 44 at r3 (raw file):

}

/// Converts `&TreeVec<&Vec<T>>` to `TreeVec<Vec<&T>>`.

Thank you! I needed this like 3 times and was always too lazy.

Copy link
Collaborator Author

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alon-Ti and @shaharsamocha7)


crates/prover/src/core/pcs/utils.rs line 44 at r3 (raw file):

Previously, Alon-Ti wrote…

Thank you! I needed this like 3 times and was always too lazy.

no problem bud

Copy link
Collaborator Author

ohad-starkware commented Dec 2, 2024

Merge activity

  • Dec 2, 4:45 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 2, 4:45 AM EST: A user merged this pull request with Graphite.

@ohad-starkware ohad-starkware merged commit e21f74f into dev Dec 2, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants