Allow out-of-crate preprocessed column definitions #939
+333
−131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an enum
PreprocessedColumn
and introduces a traitPreprocessedColumnOps
. The enum values are turned into trait implementations.Motivation
Before this PR, when a
stwo
user wanted a new column in the preprocessed column, they had to changestwo
codebase and add a value inPreprocessedColumn
enum.After this PR, they can implement
PreprocessedColumnOps
in their own crate, without touchingstwo
codebase.