Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly tests output isn't parsed properly #4587

Closed
osmaczko opened this issue Jan 18, 2024 · 3 comments · Fixed by #4599
Closed

Nightly tests output isn't parsed properly #4587

osmaczko opened this issue Jan 18, 2024 · 3 comments · Fixed by #4599
Assignees
@osmaczko
Labels
jenkins

Comments

@osmaczko
Copy link
Contributor

#4264 (comment)
@osmaczko osmaczko self-assigned this Jan 18, 2024
@osmaczko osmaczko moved this to In Progress in Status Desktop/Mobile Board Jan 18, 2024
osmaczko added a commit that referenced this issue Jan 18, 2024
@osmaczko
fix: remove color sequences from tests output
776e33f 
Removed colorized output from tests due to lack of control over various
loggers. This ensures valid input for go-junit-report.

fixes: #4587
@osmaczko osmaczko mentioned this issue Jan 18, 2024
Closed
@osmaczko osmaczko moved this from In Progress to Code review in Status Desktop/Mobile Board Jan 18, 2024
@osmaczko
Copy link
Contributor Author

@yakimant could you please check what version of go-junit-report is used on CI? Version >=v2.1.0 contains: Fix #140: Escape illegal XML characters in junit output, which should effectively fix our problem.

@yakimant
Copy link
Member

Nice finding! We have 2.0.0. Will be quite easy to upgrade:
NixOS/nixpkgs@8ee045a

I will make a PR for that.

yakimant added a commit that referenced this issue Jan 19, 2024
@yakimant
nix: go-junit-report 2.0.0 -> 2.1.0
80c5ece 
Should fix illegal XML char parsing, see
#4587
@yakimant yakimant mentioned this issue Jan 19, 2024
Merged
yakimant added a commit that referenced this issue Jan 19, 2024
@yakimant
nix: go-junit-report 2.0.0 -> 2.1.0
af3afcb 
Should fix illegal XML char parsing, see
#4587
yakimant added a commit that referenced this issue Jan 22, 2024
@yakimant
nix: go-junit-report 2.0.0 -> 2.1.0
cd9617c 
Should fix illegal XML char parsing, see
#4587
@github-project-automation github-project-automation bot moved this from Code review to Done in Status Desktop/Mobile Board Jan 22, 2024
@yakimant
Copy link
Member

@osmaczko, I've checked the test stats report, it works again.
Thanks for your finding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osmaczko osmaczko

Labels
jenkins
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
No milestone
2 participants
@yakimant @osmaczko