Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove color sequences from tests output #4589

Closed
wants to merge 2 commits into from

Conversation

osmaczko
Copy link
Contributor

Removed colorized output from tests due to lack of control over various loggers. This ensures valid input for go-junit-report.

fixes: #4587

Removed colorized output from tests due to lack of control over various
loggers. This ensures valid input for go-junit-report.

fixes: #4587
@osmaczko osmaczko requested a review from yakimant January 18, 2024 14:14
@status-im-auto
Copy link
Member

status-im-auto commented Jan 18, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 776e33f #1 2024-01-18 14:21:16 ~6 min ios 📦zip
✔️ 776e33f #1 2024-01-18 14:25:56 ~10 min android 📦aar
✔️ 776e33f #1 2024-01-18 14:27:49 ~12 min linux 📦zip
✔️ 776e33f #1 2024-01-18 15:02:29 ~47 min tests 📄log
✔️ fb11784 #2 2024-01-19 09:33:02 ~3 min ios 📦zip
✔️ fb11784 #2 2024-01-19 09:33:33 ~3 min linux 📦zip
✔️ fb11784 #2 2024-01-19 09:35:06 ~5 min android 📦aar

@osmaczko osmaczko marked this pull request as draft January 19, 2024 10:11
@osmaczko
Copy link
Contributor Author

I just realized color sequences are not the only problem here. For instance, from last nightly, the xml contained an invalid XML character (Unicode: 0xffff) in the CDATA section, exact line:

2024-01-19T03:38:53.171Z        DEBUG   common/message_sender.go:847    failed to handle segmentation layer message     {"site": "handleMessage", "hash": "\u0004{\ufffd\ufffd\ufffdZ<ffff>)\u0002\ufffd\ufffd\ufffdE5\ufffd٧\u001c\ufffd\ufffd\ufffd<\ufffd\ufffdƒ\u0008\ufffd\ufffd*", "error": "NOT NULL constraint failed: message_segments.payload"}

@osmaczko
Copy link
Contributor Author

Closing, the solution is to update the tool itself: #4587 (comment)

@osmaczko osmaczko closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly tests output isn't parsed properly
2 participants