Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_: add infuraSecret and statusProxyBlockchainPassword to secrets #6217

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

igor-sirotin
Copy link
Collaborator

No description provided.

@status-im-auto
Copy link
Member

status-im-auto commented Dec 16, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b25c4a1 #1 2024-12-16 18:34:51 ~4 min macos 📦zip
✔️ b25c4a1 #1 2024-12-16 18:34:57 ~4 min ios 📦zip
✔️ b25c4a1 #1 2024-12-16 18:35:31 ~5 min linux 📦zip
✔️ b25c4a1 #1 2024-12-16 18:35:45 ~5 min windows 📦zip
✔️ b25c4a1 #1 2024-12-16 18:35:46 ~5 min android 📦aar
✖️ b25c4a1 #1 2024-12-16 18:36:53 ~6 min tests-rpc 📄log
✔️ b25c4a1 #1 2024-12-16 18:38:29 ~8 min macos 📦zip
✔️ b25c4a1 #2 2024-12-16 18:46:52 ~6 min tests-rpc 📄log
✔️ b25c4a1 #1 2024-12-16 19:00:45 ~30 min tests 📄log

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.27%. Comparing base (c27c773) to head (b25c4a1).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6217       +/-   ##
============================================
+ Coverage    19.34%   61.27%   +41.92%     
============================================
  Files          811      833       +22     
  Lines       107904   109925     +2021     
============================================
+ Hits         20877    67357    +46480     
+ Misses       84202    34718    -49484     
- Partials      2825     7850     +5025     
Flag Coverage Δ
functional 19.43% <ø> (+0.08%) ⬆️
unit 60.07% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mobile/callog/status_request_log.go 87.34% <ø> (+50.63%) ⬆️

... and 632 files with indirect coverage changes

@igor-sirotin igor-sirotin merged commit 2172abe into develop Dec 17, 2024
21 checks passed
@igor-sirotin igor-sirotin deleted the fix/secret-leaks-in-api-log branch December 17, 2024 09:41
@jakubgs
Copy link
Member

jakubgs commented Jan 2, 2025

Wait, are we still embedding infura tokens into the app? Then what is the proxy for?

@igor-sirotin
Copy link
Collaborator Author

@jakubgs afaik, we have fallbacks if proxy fails.
Also, user can define their own rpc provider to be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants