feat(nwaku): add protected topics #6220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require commits to follow the Conventional Commits, but with |
Jenkins BuildsClick to see older builds (8)
|
richard-ramos
force-pushed
the
feat-nwaku-topics
branch
from
a17c2bc to
569c76b
Compare
richard-ramos
force-pushed
the
feat-nwaku-topics
branch
from
569c76b to
3592424
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/nwaku-in-status #6220 +/- ##
===============================================
===============================================
|
|
|
||
| if pubkey != nil { | ||
| err := w.node.Relay().AddSignedTopicValidator(topic, pubkey) | ||
| err := w.node.RelayAddProtectedShard(rs[0].ClusterID, rs[0].ShardIDs[0], pubkey) |
There was a problem hiding this comment.
I wonder if we should also make sure rs[0].ShardIDs.len != 0
| @@ -2642,6 +2660,37 @@ func (n *WakuNode) RelaySubscribe(pubsubTopic string) error { | |||
| return errors.New(errMsg) | |||
| } | |||
|
|
|||
| func (n *WakuNode) RelayAddProtectedShard(clusterId uint16, shardId uint16, pubkey *ecdsa.PublicKey) error { | |||
| if pubkey == nil { | |||
| return nil // Nothing to do here | |||
There was a problem hiding this comment.
Isn't it better to return an error in this case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.