added jsondecoding/encoding key support for smart unwrap requests #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -197,6 +197,9 @@ public extension Request where | |||
| decoder.userInfo = [ | |||
| .smartUnwrapKey: smartUnwrapKey | |||
| ] | |||
| decoder.dateDecodingStrategy = .iso8601 | |||
There was a problem hiding this comment.
What's the motivation for adding this line? Isn't this the default anyways?
There was a problem hiding this comment.
It was just for consistency, as I wanted to this request to have the same decoding structure as the original request. Line 120 & 121 in the original file are what I wanted to bring to the request, so we didn't meet weird discrepancies if including unwrap.
There was a problem hiding this comment.
makes sense, i didnt realize we did that in request already!
brendanlensink
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requests using smart unwrap were missing the addition of the decoding/encoding lines, which meant the request always failed if a user provided a key while also using smart unwrap. I added support in. This is unrelated to Issue #108.