-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[92] progress without error #117
Conversation
cd00a64
to
2526949
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple suggestions/comments to think about
Also we should probably bump the library version since we're adding new functionality ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, before merging don't forget to add a blurb to the README explaining intended use 🚀
6d67d6a
to
83cbe7d
Compare
@brendanlensink this is merged! You said you were going to do the tag and release stuff so just nudging about that! 👀 |
This PR adds in the ability for a request to have a postProcessing method. To implement it, I have done the following:
postProcess
method to Netable request, that by default returns theFinalResource
. This will now be the final method run through every request.FinalResource
is returned.Example
project, where we have a Data Manager that stores a user. TheGetUserRequest
implements thepostProcess
method, where we send the user to the shared user object in the DataManager before returning the finalResource.Note: I also removed the target here for the old example. I think that was also done in the sendable ticket which hasn't been merged, but if not it's done here now! Whichever ticket is merged first, I will rebase the other, so it shouldn't matter.