Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit check #36

Merged
merged 12 commits into from
Oct 4, 2024
Merged

Add pre-commit check #36

merged 12 commits into from
Oct 4, 2024

Conversation

stefanDeveloper
Copy link
Owner

No description provided.

@stefanDeveloper stefanDeveloper self-assigned this Oct 2, 2024
@stefanDeveloper stefanDeveloper linked an issue Oct 2, 2024 that may be closed by this pull request
Add pre-commit check in GitHub Actions #34
Closed
@stefanDeveloper stefanDeveloper added this to the First heiDGAF version milestone Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1188 1082 91% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/base/logline_handler.py 100% 🟢
src/base/utils.py 100% 🟢
src/detector/detector.py 94% 🟢
src/inspector/inspector.py 86% 🟢
src/logcollector/batch_handler.py 100% 🟢
src/logcollector/collector.py 100% 🟢
src/logserver/server.py 100% 🟢
TOTAL 97% 🟢

updated for commit: cc91e9f by action🐍

lamr02n
lamr02n reviewed Oct 3, 2024
View reviewed changes
docs/usage.rst Outdated Show resolved Hide resolved
lamr02n
lamr02n previously requested changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@lamr02n lamr02n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we just need to add the LogServer's requirements file to some commands (see comments).

@stefanDeveloper stefanDeveloper added the enhancement New feature or request label Oct 4, 2024
lamr02n
lamr02n reviewed Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@lamr02n lamr02n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one spot where the requirements are still missing

.readthedocs.yml Show resolved Hide resolved
@stefanDeveloper stefanDeveloper dismissed lamr02n’s stale review October 4, 2024 09:44

Logserver requirement in .readthedocs.yml will added later, actually not related to this PR.

@stefanDeveloper stefanDeveloper merged commit 02b11b2 into main Oct 4, 2024
15 checks passed
@stefanDeveloper stefanDeveloper deleted the 34-add-pre-commit-check-in-github-actions branch October 4, 2024 09:48
@stefanDeveloper stefanDeveloper mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamr02n lamr02n lamr02n left review comments

Assignees

@stefanDeveloper stefanDeveloper

Labels
enhancement New feature or request
Projects
None yet
Milestone
First heiDGAF version
Development

Successfully merging this pull request may close these issues.

Add pre-commit check in GitHub Actions
2 participants
@stefanDeveloper @lamr02n