Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify LogServer, Collector and KafkaHandlers #55

Merged
merged 31 commits into from
Nov 25, 2024

Conversation

lamr02n
Copy link
Collaborator

@lamr02n lamr02n commented Nov 20, 2024

To improve the performance of the LogServer and Collector as well as enhance the capabilities of the KafkaHandlers, all three modules were heavily updated. LogServer and Collector were completely rewritten and simplified to the most important functionalities.

@lamr02n lamr02n added the enhancement New feature or request label Nov 20, 2024
@lamr02n lamr02n added this to the First heiDGAF version milestone Nov 20, 2024
@lamr02n lamr02n self-assigned this Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1150 1144 99% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/base/kafka_handler.py 100% 🟢
src/base/log_config.py 100% 🟢
src/base/utils.py 100% 🟢
src/detector/detector.py 99% 🟢
src/inspector/inspector.py 98% 🟢
src/logcollector/batch_handler.py 100% 🟢
src/logcollector/collector.py 100% 🟢
src/logserver/server.py 100% 🟢
src/prefilter/prefilter.py 100% 🟢
TOTAL 100% 🟢

updated for commit: f7f842e by action🐍

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.86%. Comparing base (e639f8b) to head (f7f842e).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   93.21%   98.86%   +5.65%     
==========================================
  Files          11       11              
  Lines        1267     1150     -117     
  Branches      126      125       -1     
==========================================
- Hits         1181     1137      -44     
+ Misses         78        6      -72     
+ Partials        8        7       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lamr02n
Copy link
Collaborator Author

lamr02n commented Nov 20, 2024

Please note that some tests are still work in progress. Ignore those for now.

@lamr02n
Copy link
Collaborator Author

lamr02n commented Nov 23, 2024

All tests are now updated.

Copy link
Owner

@stefanDeveloper stefanDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@stefanDeveloper stefanDeveloper merged commit b63456f into main Nov 25, 2024
17 checks passed
@lamr02n lamr02n deleted the simplify-logserver-and-collector branch November 25, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants