Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler and documentation cleanup #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Compiler and documentation cleanup #8

wants to merge 3 commits into from

Conversation

rhizoome
Copy link
Contributor

@rhizoome rhizoome commented May 1, 2017

  • Enable -Werror
  • Fix remaining compiler errors
  • Fix documentation error

@stefanct this is minor cleanup.

Copy link
Owner

@stefanct stefanct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the problem with the empty braces?
And why is that dim there in the first place? :)

@rhizoome
Copy link
Contributor Author

rhizoome commented May 2, 2017

  1. Half a year ago gcc on my system used to complained something like:

No body not allowed by ISO-C.

Now its ok, again, gcc seems not decided on the issue. I'll revert it. Since I already added the {}.

  1. Without the dim:
$> gcc -I.. queue.c
queue.c: In function 'sglib_iq_is_full':
queue.c:18:1: error: macro "SGLIB_QUEUE_IS_FULL" requires 5 arguments, but only 4 given
SGLIB_DEFINE_QUEUE_FUNCTIONS(iq, int, a, i, j, MAX_PARAMS);

Its quite obvious the macro-body has dim and the called macro wants dim.

@stefanct I'm quite curious if Marian Vittek wil answer his email. 😄

Jean-Louis Fuchs added 3 commits May 2, 2017 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants