Clearly protect against algorithm confusion attack #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @desfero 👋 Thanks for the PR! Could you please run the I will check the implementation and let you. And very sorry for the delay 😞 |
# Conflicts: # src/test/verifyAppleIdToken.test.ts
|
@stefanprokopdev seems everything is formatted properly as no changes after running |
stefanprokopdev
approved these changes
Nov 15, 2023
@desfero thank you so much! Already released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the validation logic to catch JWT algorithm confusion attacks earlier and not assume that it's handled by internals of jsonwebtoken verification logic.