Fail load gen if soroban invoke without setup #4564
+17
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4559 changed load gen to throw an exception with an error message if a user generated load in
MODE::SOROBAN_INVOKE
mode, without first runningMODE::SOROBAN_INVOKE_SETUP
.This PR reverts that change and instead logs an error message and calls
emitFailure
to incrementloadgen.run.failed
and reset the state. It tests that this metric is incremented in this case.Checklist
clang-format
v8.0.0 (viamake format
or the Visual Studio extension)