Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail load gen if soroban invoke without setup #4564

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ThomasBrady
Copy link
Contributor

#4559 changed load gen to throw an exception with an error message if a user generated load in MODE::SOROBAN_INVOKE mode, without first running MODE::SOROBAN_INVOKE_SETUP.

This PR reverts that change and instead logs an error message and calls emitFailure to increment loadgen.run.failed and reset the state. It tests that this metric is incremented in this case.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@ThomasBrady ThomasBrady force-pushed the loadgen-misconfig-fail-no-exception branch from 7e1955f to 8313843 Compare December 9, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant