Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FC43 Frame Writer and Improvements #142

Open
wants to merge 42 commits into
base: iware/review
Choose a base branch
from

Commits on Feb 26, 2024

  1. Merge remote-tracking branch 'origin/iware/review' into feature/fc43-…

    …temp
    Kay Grewe authored and Kay Grewe committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    e8efaa6 View commit details
    Browse the repository at this point in the history
  2. refactor(read_device_info_handler): change return type.

    Kay Grewe authored and Kay Grewe committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    5f4c64f View commit details
    Browse the repository at this point in the history
  3. refactor(get_reply): store the data returned by the handler, add todo!()

    Kay Grewe authored and Kay Grewe committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    9bf03e8 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. refactor(response): add option arg to callback, change return type.

    Kay Grewe authored and Kay Grewe committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    2324bde View commit details
    Browse the repository at this point in the history
  2. refactor(ServerDeviceInfo): add derived traits to struct.

    Kay Grewe authored and Kay Grewe committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    232d8e2 View commit details
    Browse the repository at this point in the history
  3. refactor(response_message_count): comment out old code for now

    Kay Grewe authored and Kay Grewe committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    a475ec9 View commit details
    Browse the repository at this point in the history
  4. refactor(integration_tests): change response of integration tests.

    Kay Grewe authored and Kay Grewe committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    38b8a8f View commit details
    Browse the repository at this point in the history
  5. refactor(get_reply): do some calculations before passing the index on

    Kay Grewe authored and Kay Grewe committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    cbfb469 View commit details
    Browse the repository at this point in the history
  6. refactor(server): testing how to pass slices from functions...

    Kay Grewe authored and Kay Grewe committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    fedc5aa View commit details
    Browse the repository at this point in the history
  7. refactor(trait serialize): change the serialization of read device info

    Kay Grewe authored and Kay Grewe committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    6d92494 View commit details
    Browse the repository at this point in the history
  8. refactor(server): remove import and use the direct path of the enum.

    Kay Grewe authored and Kay Grewe committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    babd8be View commit details
    Browse the repository at this point in the history
  9. chore(read device identification): rustfmt

    Kay Grewe authored and Kay Grewe committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    6f4e62d View commit details
    Browse the repository at this point in the history
  10. refactor(frame): add FrameRecords struct and change serialize trait.

    Kay Grewe authored and Kay Grewe committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    274399f View commit details
    Browse the repository at this point in the history
  11. refactor(serialize trait): add recorder into serialize trait

    Kay Grewe authored and Kay Grewe committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    3c144b3 View commit details
    Browse the repository at this point in the history
  12. refactor(serialize): pass none where no recorder is necessary

    Kay Grewe authored and Kay Grewe committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    a5979ab View commit details
    Browse the repository at this point in the history
  13. chore(grammar): remove double "the" from doc comment

    Kay Grewe authored and Kay Grewe committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    5d09fb2 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. tests(frame): fix the frame tests by adding the now necessary frame rec.

    Kay Grewe authored and Kay Grewe committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    5011f28 View commit details
    Browse the repository at this point in the history
  2. refactor(frame_recorder): Improve the API of the FrameRecorder.

    Kay Grewe authored and Kay Grewe committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    6fc31f5 View commit details
    Browse the repository at this point in the history
  3. feat(RecorderError): add a new error type for the frame recorder

    Kay Grewe authored and Kay Grewe committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    8b085f2 View commit details
    Browse the repository at this point in the history
  4. refactor(server_device_info): add read_device_code back into the struct

    Kay Grewe authored and Kay Grewe committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    5b6c4e0 View commit details
    Browse the repository at this point in the history
  5. refactor(server_device_info): add read_device_code field.

    Kay Grewe authored and Kay Grewe committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    69ea1b3 View commit details
    Browse the repository at this point in the history
  6. refactor(serialize): change usage of FrameRecorder API

    Kay Grewe authored and Kay Grewe committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    1b401bf View commit details
    Browse the repository at this point in the history
  7. refactor(server): temporary add field to returned dummy value.

    Kay Grewe authored and Kay Grewe committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    823cbff View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. refactor(handler): add current_object_id to ReadDeviceInfo struct

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    899355c View commit details
    Browse the repository at this point in the history
  2. refactor(serialize): object by object serialization for FC43

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    02ebb9a View commit details
    Browse the repository at this point in the history
  3. feat(error): add frame record errors to the InternalError enum

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c097976 View commit details
    Browse the repository at this point in the history
  4. refactor(frame): get rid of the unwraps in the fill_record method

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    3df08a3 View commit details
    Browse the repository at this point in the history
  5. feat(frame): add handling of non-empty frame recorders before sending

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    488e085 View commit details
    Browse the repository at this point in the history
  6. refactor(request): remove unnecessary stuff from the way fc43 is handled

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    1cfe7b9 View commit details
    Browse the repository at this point in the history
  7. test(integration_tests): change the code that generates the response

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    76e5e1d View commit details
    Browse the repository at this point in the history
  8. feat(ffi): add FrameRecorderNotEmpty conversion into InternalError

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    049e7ea View commit details
    Browse the repository at this point in the history
  9. refactor(message): make the FrameRecorder argument invisible.

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    d338561 View commit details
    Browse the repository at this point in the history
  10. chore(read_device_ident): cargo fmt improvements

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    e6a817c View commit details
    Browse the repository at this point in the history
  11. refactor(frame): remove unnecessary imports, unnecessary clone, run fmt

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    9c7b75f View commit details
    Browse the repository at this point in the history
  12. refactor(serialize): remove unnecessary imports, make records invisible

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    084197c View commit details
    Browse the repository at this point in the history
  13. chore(traits): cargo fmt formatting applied

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    7e355c6 View commit details
    Browse the repository at this point in the history
  14. chore(frame): cargo fmt formatting applied

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    b26e1a4 View commit details
    Browse the repository at this point in the history
  15. refactor(error): remove unnecessary import, apply cargo formatting

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    edcfc09 View commit details
    Browse the repository at this point in the history
  16. chore(request): apply cargo formatting

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    01196a8 View commit details
    Browse the repository at this point in the history
  17. refactor(response): remove unnecessary imports, apply cargo formatting

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    342edb4 View commit details
    Browse the repository at this point in the history
  18. chore(frame): apply cargo formatting

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    b032c00 View commit details
    Browse the repository at this point in the history
  19. chore(e2e_read_device): remove commented code, apply cargo formatting

    Kay Grewe authored and Kay Grewe committed May 22, 2024
    Configuration menu
    Copy the full SHA
    0ec01f4 View commit details
    Browse the repository at this point in the history