Add Puppeteer Settings #510
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppeteer Browser Settings - adding ability to set puppeteer browser options from package json. ** example use case: firestore cli keeps an open socket connection, need to set waitUntil to networkidle2 to prevent error precomiling files ( + needed devtools option set to true to be able to debug network connection in non-headless browser to figure out network issues)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Puppeteer Browser Settings - adding ability to set puppeteer browser options from package json. Example use case: firestore cli keeps an open socket connection, need to set waitUntil to networkidle2 to prevent error precompiling files ( + needed devtools option set to true to be able to debug network connection in non-headless browser to figure out network issues ). This pull will incorporate https://pptr.dev/#?product=Puppeteer&version=v5.5.0&show=api-puppeteerlaunchoptions
💔Thank you!