fix: open_output respects configured toggleterm size

.github/workflows/tests.yml

@@ -45,7 +45,7 @@ jobs:
       - uses: stevearc/nvim-typecheck-action@v2
         with:
           path: lua
-          libraries: https://github.com/nvim-neotest/neotest https://github.com/mfussenegger/nvim-dap
+          libraries: https://github.com/nvim-neotest/neotest https://github.com/mfussenegger/nvim-dap https://github.com/akinsho/toggleterm.nvim
 
   run_tests:
     strategy:

Makefile

@@ -10,7 +10,7 @@ test:
 	./run_tests.sh
 
 lint: scripts/nvim-typecheck-action fastlint
-	./scripts/nvim-typecheck-action/typecheck.sh --lib https://github.com/nvim-neotest/neotest --lib https://github.com/mfussenegger/nvim-dap --workdir scripts/nvim-typecheck-action lua
+	./scripts/nvim-typecheck-action/typecheck.sh --lib https://github.com/nvim-neotest/neotest --lib https://github.com/mfussenegger/nvim-dap --lib https://github.com/akinsho/toggleterm.nvim --workdir scripts/nvim-typecheck-action lua
 
 fastlint: scripts/nvim_doc_tools
 	python scripts/main.py lint

lua/overseer/strategy/toggleterm.lua

@@ -6,6 +6,7 @@ local terminal = require("toggleterm.terminal")
 
 ---@class overseer.ToggleTermStrategy : overseer.Strategy
 ---@field private opts overseeer.ToggleTermStrategyOpts
+---@field private term? Terminal
 local ToggleTermStrategy = {}
 
 ---@class overseeer.ToggleTermStrategyOpts
@@ -145,4 +146,11 @@ function ToggleTermStrategy:dispose()
   end
 end
 
+---@param direction "float"|"tab"|"vertical"|"horizontal"
+function ToggleTermStrategy:open_terminal(direction)
+  if self.term then
+    self.term:open(self.opts.size, direction)
+  end
+end
+
 return ToggleTermStrategy

lua/overseer/task.lua

@@ -441,11 +441,7 @@ function Task:open_output(direction)
   -- gross if statement here.
   if self.strategy.name == "toggleterm" and direction then
     ---@diagnostic disable-next-line: undefined-field
-    local term = self.strategy.term
-    if not term then
-      return
-    end
-    term:open(nil, direction)
+    self.strategy:open_terminal(direction)
     return
   end