feat: on_result_diagnostics_quickfix can preserve window focus #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevearc
requested changes
Dec 4, 2023
There was a problem hiding this comment.
I appreciate making the PR in a way that doesn't change the existing behavior, but in this case I do think the behavior is more of an oversight than anything. Maybe not a bug, but I don't think it's a feature. I think it makes sense to make it consistent with on_output_quickfix, and if anyone wants the old behavior of focusing the quickfix they can submit a PR that adds this option.
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses my request in #234 to allow the opening of the quickfix window by
on_result_diagnostics_quickfixto keep the focus where it was (by saving the current window ID beforecopenand then restoring it).This is implemented as an option, defaulting off to preserve existing behavior for users who may want that. I noticed while looking for other places to apply this, however, that
on_output_quickfixpreserves the window focus in the same way I did, which makes me wonder if the focus-stealing thaton_result_diagnostics_quickfixdoes is really a bug and whether the desired solution would be to never steal the focus? It would be a simpler change, but would also change behavior for anybody who has been relying onon_result_diagnostics_quickfixputting the cursor into the quickfix window when it opens.