Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix template to set working dir for task #295

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

hori-ryota
Copy link
Contributor

@hori-ryota hori-ryota commented May 25, 2024

update task template to execute tasks in cwd of list tasks executed (for Taskfiles in child dirs)

@github-actions github-actions bot requested a review from stevearc May 25, 2024 06:17
@hori-ryota hori-ryota force-pushed the feature/cwd-for-task branch from 085c13d to e8dec44 Compare May 25, 2024 06:19
@stevearc
Copy link
Owner

stevearc commented Jun 3, 2024

Can you provide some more details about the situation you are encountering and the problem you are facing? Some more context will help me determine if this is the best approach or if there is perhaps a better solution to your issue.

@stevearc stevearc removed their request for review June 3, 2024 17:59
@hori-ryota
Copy link
Contributor Author

@stevearc When there is a Taskfile in a subdirectory, tasks can only be executed within that subdirectory.

Currently, if you open a Taskfile in a subdirectory and run OverseerRun, the tasks that can be executed in that subdirectory are listed. However, when you actually execute a task, it runs in the current directory (the parent directory), fails to find the task, and execution fails.

Therefore, this pull request aims to enable the correct execution of tasks in the subdirectory by running the tasks in the directory of the opened file.

@stevearc
Copy link
Owner

stevearc commented Jun 9, 2024

Makes sense, thanks for the PR!

@stevearc stevearc merged commit 5fc6848 into stevearc:master Jun 9, 2024
9 checks passed
@hori-ryota hori-ryota deleted the feature/cwd-for-task branch June 10, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants