Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vscode task hide option was not set correctly #329

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix: vscode task hide option was not set correctly #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lua/overseer/template/vscode/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,9 @@ local function convert_vscode_task(defn, precalculated_vars)
end
end
end
if defn.hide then
tmpl.hide = true
end
if defn.dependsOn then
if type(defn.dependsOn) == "string" then
defn.dependsOn = { defn.dependsOn }
Expand Down Expand Up @@ -297,9 +300,6 @@ local function convert_vscode_task(defn, precalculated_vars)
)
return nil
end
if defn.hide then
tmpl.hide = true
end

-- NOTE: we intentionally do nothing with defn.runOptions.
-- runOptions.reevaluateOnRun unfortunately doesn't mesh with how we re-run tasks
Expand Down