Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exit for fish shell #345

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix: exit for fish shell #345

merged 1 commit into from
Aug 19, 2024

Conversation

lucobellic
Copy link
Contributor

Using fish with use_shell generate the following error:

fish: $? is not the exit status. In fish, please use $status.

This quick fix handle exit for fish, let me know if you prefer to add a function in shell.lua

@github-actions github-actions bot requested a review from stevearc August 17, 2024 19:35
@stevearc
Copy link
Owner

This is fine for now, thanks!

@stevearc stevearc merged commit 2c1ef39 into stevearc:master Aug 19, 2024
9 checks passed
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevearc stevearc Awaiting requested review from stevearc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucobellic @stevearc